Differential D3155

Call GLRenderTarget::setVirtualScreenGeometry prior to self test
ClosedPublic
Actions

Authored by graesslin on Oct 25 2016, 7:32 AM.

Details

Reviewers
bshah
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:f792c82528d4: Call GLRenderTarget::setVirtualScreenGeometry prior to self test
Summary

The shader self test uses GLRenderTarget and restores the viewport. Due
to the setVirtualScreenGeometry not being set the calculated viewport is
incorrect and any rendering breaks. This is a regression introduced with
1708278a451e6dab92549f9cabe6ad13ea3b4ba2 which only affects Wayland
backends which do not perform per screen rendering.

The glxbackend was not affected as it sets the viewport on screen
geometry change.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7645.Oct 25 2016, 7:32 AM
graesslin retitled this revision from to Call GLRenderTarget::setVirtualScreenGeometry prior to self test.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland, bshah.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptOct 25 2016, 7:32 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
bshah accepted this revision.Oct 25 2016, 7:34 AM
bshah edited edge metadata.
This revision is now accepted and ready to land.Oct 25 2016, 7:34 AM
Closed by commit R108:f792c82528d4: Call GLRenderTarget::setVirtualScreenGeometry prior to self test (authored by graesslin, committed by bshah). · Explain WhyOct 25 2016, 8:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mscene_opengl.cpp (1 line)

Diff 7647

View Options

scene_opengl.cpp

Loading...