Trigger resize of input window when deco size changes
ClosedPublic

Authored by graesslin on Oct 24 2016, 1:16 PM.

Details

Summary

Client::updateInputWindow operates with the decoration size. The method
gets called from various points when changing the window geometry. If at
that moment the decoration has not updated yet, the borders might be at
a wrong position.

This behavior could be triggered when a window requested to change the
state to maximized. During maximization the decoration still had the
wrong size when updateInputWindow was called, thus an interactive area
inside the window was created.

To circumvent this problem updateInputWindow is now also called whenever
the window decoration changes.

As a note: that a maximized window has resize only borders is wrong. Kwin
should be protected against that.

BUG: 371284
FIXED-IN: 5.8.3

Test Plan

Checked xwininfo for the deco extends window

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7634.Oct 24 2016, 1:16 PM
graesslin retitled this revision from to Trigger resize of input window when deco size changes.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptOct 24 2016, 1:16 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Oct 28 2016, 1:57 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Oct 28 2016, 1:57 PM
This revision was automatically updated to reflect the committed changes.