Pass transient parent window to KToolTipWindow
ClosedPublic
Actions

Authored by graesslin on Oct 19 2016, 1:22 PM.

Details

Reviewers

davidedmundson
bcooksley

Group Reviewers

Plasma

Commits

R124:25ffff6b4a1d: Pass transient parent window to KToolTipWindow

Summary

This fixes tooltips on Wayland. We need the relationship to the
transient parent window - tooltips are positioned relative to their
parent window. Also on X11 this is an important information which was
completely lacking.

Before the change the tooltips got randomly positioned by the Wayland
compositor as it thought that it is a new toplevel window. With the
change the tooltip gets shown where it is supposed to be shown.

Test Plan

Run systemsettings with --platform wayland and xcb

Diff Detail

Repository

R124 System Settings

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 7546.Oct 19 2016, 1:22 PM

graesslin retitled this revision from to Pass transient parent window to KToolTipWindow.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptOct 19 2016, 1:22 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

graesslin added a reviewer: bcooksley.Oct 19 2016, 1:22 PM

davidedmundson accepted this revision.Oct 19 2016, 1:26 PM

davidedmundson added a reviewer: davidedmundson.

This revision is now accepted and ready to land.Oct 19 2016, 1:26 PM

This looks fine to me. The whole KToolTip class thing should at some point be replaced or merged with the code which Dolphin and KInfoCenter use - which is basically the same last I recall.

In D3112#57826, @bcooksley wrote:

This looks fine to me. The whole KToolTip class thing should at some point be replaced or merged with the code which Dolphin and KInfoCenter use - which is basically the same last I recall.

Dolphin code seems to have evolved. At least lxr didn't show usage of KToolTip in Dolphin. And yes I'm quite annoyed by the code forks as it means doing the same fix in multiple places.

Closed by commit R124:25ffff6b4a1d: Pass transient parent window to KToolTipWindow (authored by graesslin). · Explain WhyOct 20 2016, 9:43 AM

This revision was automatically updated to reflect the committed changes.