Differential D3090

Move entryRemoved signal to the read-write interface
ClosedPublic
Actions

Authored by elvisangelaccio on Oct 17 2016, 6:17 PM.

Details

Reviewers
rthomsen
Commits
R36:768117e66f37: Move entryRemoved signal to the read-write interface
Summary

Read-only interfaces cannot remove entries, so they can never emit this
signal.

Test Plan

Builds.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 7471.Oct 17 2016, 6:17 PM
elvisangelaccio retitled this revision from to Move entryRemoved signal to the read-write interface.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptOct 17 2016, 6:17 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Oct 17 2016, 6:34 PM
rthomsen edited edge metadata.

Looks good :)

This revision is now accepted and ready to land.Oct 17 2016, 6:34 PM

Revision Contents
Changeset List

Diff 7478

View Options

kerfuffle/archiveinterface.h

Loading...
View Options

kerfuffle/archiveinterface.cpp

Loading...
View Options

kerfuffle/jobs.cpp

Loading...