Hide "automatic login" button in UserAccounts since is does absolutely nothing
ClosedPublic

Authored by davidedmundson on Oct 14 2016, 10:25 PM.

Details

Summary

automaticLogin only sets a flag in AccountsService, which is only
supported by GDM.
Hide it until that is different.

A working automatic login option is available in the UI in the SDDM KCM.

BUG: 363058

Test Plan

Looked at it.

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Hide "automatic login" button in UserAccounts since is does absolutely nothing.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 14 2016, 10:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg added inline comments.
src/accountinfo.cpp
66

Maybe only hide the checkbox and add a small description for users, that they can find the option in the sddm kcm for now.

On further investigation, the AccountsService automaticlogin thing will /never/ work.
It writes into etc/gdm/custom.conf and if that doesn't exist, it will just retun an error.

So it's not a case of just making SDDM do this, and this isn't a temporary measure.

At which point I might either:

make it just execute the SDDMKCM kauth action to set the autologin setting.

or just delete it: it's weird to have the same setting in two places anyway

I would just delete it, because as you say having the same settings in two places is messy. But if there is a nice way of informing the user about the different place of the setting, we should do that.

mart added a subscriber: mart.Oct 17 2016, 9:28 AM

shouldn't be completely removed then?

mart accepted this revision.Nov 7 2016, 1:56 PM
mart added a reviewer: mart.

updates on that? could this just go in?

This revision is now accepted and ready to land.Nov 7 2016, 1:56 PM
This revision was automatically updated to reflect the committed changes.