Pass the current output geometry to ScreenPaintData
ClosedPublic
Actions

Authored by graesslin on Oct 14 2016, 1:52 PM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:359224a5dcf9: Pass the current output geometry to ScreenPaintData

Summary

On Wayland per output rendering is performed and paintScreen is invoked
for every output. Some effects need the information which output is
currently being rendered as otherwise e.g. FBO access could fail.

This change adds the current output geometry to ScreenPaintData. On X11
(all outputs one geometry) this information is not set and a null rect
is returned. That way the effects can also easily check which rendering
mode is used.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 7395.Oct 14 2016, 1:52 PM

graesslin retitled this revision from to Pass the current output geometry to ScreenPaintData.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptOct 14 2016, 1:52 PM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

graesslin added a dependent revision: D3059: [effects] Make screenshot effect work with multiple output rendering.Oct 14 2016, 1:54 PM

sebas accepted this revision.Oct 16 2016, 3:02 PM

sebas added a reviewer: sebas.

This revision is now accepted and ready to land.Oct 16 2016, 3:02 PM

Closed by commit R108:359224a5dcf9: Pass the current output geometry to ScreenPaintData (authored by graesslin). · Explain WhyOct 17 2016, 7:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/test_screen_paint_data.cpp (9 lines)
M			libkwineffects/kwineffects.h (12 lines)
M			libkwineffects/kwineffects.cpp (11 lines)
M			scene.h (2 lines)
M			scene.cpp (4 lines)
M			scene_opengl.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7395	e9b25f1		Oct 14 2016, 1:52 PM	★	★
Diff 2	7449	4e9a1ee	rKWIN359224a5dcf9ef22f2c5f059f920f3f5f799012b	Oct 17 2016, 7:02 AM	★	★

Status	Author	Revision
Closed	graesslin	D3059 [effects] Make screenshot effect work with multiple output rendering
Closed	graesslin	D3058 Pass the current output geometry to ScreenPaintData
Closed	graesslin	D3056 Fix glBlitFramebuffer for per-output rendering