Fix async rendering of map item
ClosedPublic

Authored by piggz on Oct 11 2016, 5:20 PM.

Details

Summary

Retry the render while items are downloading
Notify via a signal when async rendering has finished

Test Plan

Using POI.kexi and a clean cache of marble, open the report

Diff Detail

Repository
R14 KReport
Branch
fix_map_async
Lint
No Linters Available
Unit
No Unit Test Coverage
piggz updated this revision to Diff 7319.Oct 11 2016, 5:20 PM
piggz retitled this revision from to Fix async rendering of map item.
piggz updated this object.
piggz edited the test plan for this revision. (Show Details)
piggz added a reviewer: staniek.
Restricted Application added a project: KReport. · View Herald TranscriptOct 11 2016, 5:20 PM
staniek requested changes to this revision.Oct 11 2016, 5:37 PM
staniek edited edge metadata.

Thanks.

src/plugins/maps/KReportMapRenderer.cpp
61

Let's not enable such debug by default.

84

Let's not enable such debug by default.

105–122

Let's not enable such debug by default.

113

Let's not enable such debug by default.

src/plugins/maps/KReportMapRenderer.h
52

Is it used somewhere?

src/renderer/KReportPreRenderer.cpp
400–401

Don't we need to call deleteLater() on asyncManager instead because this slot is connected to asyncManager?

401

-> emit finishedAllASyncItems()

src/renderer/KReportView.cpp
159

Maybe this name could tell us more: refreshCurrentPage()?

161

Let's not enable such debug by default.

This revision now requires changes to proceed.Oct 11 2016, 5:37 PM
staniek edited edge metadata.Oct 11 2016, 5:37 PM
staniek added a subscriber: Kexi-Devel-list.
piggz updated this revision to Diff 7321.Oct 11 2016, 6:29 PM
piggz edited edge metadata.
piggz marked 9 inline comments as done.
  • Fix review issues
staniek accepted this revision.Oct 11 2016, 7:08 PM
staniek edited edge metadata.

Good work, better than before!

This revision is now accepted and ready to land.Oct 11 2016, 7:08 PM
piggz added a comment.Oct 11 2016, 7:11 PM

To force marble to download, issue
rm -rf ~/.local/share/marble/maps/earth

This revision was automatically updated to reflect the committed changes.