Fix crash when moving files with clizip
ClosedPublic

Authored by elvisangelaccio on Oct 11 2016, 4:41 PM.

Details

Summary

Entry objects are created by the plugins, so it is wrong to delete them from other
places.

movetest still fails, that will be addressed later.

Test Plan

Crash in T3988 is now fixed

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio retitled this revision from to Fix crash when moving files with clizip.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a project: Ark. · View Herald TranscriptOct 11 2016, 4:41 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
  • Upload correct patch
  • Fix libarchive entries, we need to manually delete them because they're created in a different thread and we thus can't set a parent.
  • Drop Entry::clear(), which was also deleting entries.
rthomsen accepted this revision.Oct 12 2016, 4:44 PM
rthomsen edited edge metadata.

Looks good. Fixes the crash for me.

This revision is now accepted and ready to land.Oct 12 2016, 4:44 PM
This revision was automatically updated to reflect the committed changes.