Maniphest T3988

Fix crash when moving files with clizip
Closed, ResolvedPublic
Actions

Tags

Subscribers

kde-utils-devel, elvisangelaccio

Assigned To

None

Authored By

elvisangelaccio, Oct 10 2016

Description

The CI doesn't have p7zip (which is not affected by this bug), so it falls back on clizip with which this test fails.

To reproduce locally:

Uninstall p7zip
Open autotest/kerfuffle/data/test.zip
Move a.txt into empty_dir => boom.

Details

Commits: D3027 / R36:377dfcfebdd6: Fix crash when moving files with clizip

Related Objects

Mentioned In: D3027: Fix crash when moving files with clizip

elvisangelaccio created this task.Oct 10 2016, 5:33 PM

So the crash is caused by the delete in Entry::removeEntryAt()

However, if we don't delete the entry here, other tests break :/

elvisangelaccio mentioned this in D3027: Fix crash when moving files with clizip.Oct 11 2016, 4:41 PM

elvisangelaccio added a revision: D3027: Fix crash when moving files with clizip.Oct 11 2016, 6:26 PM

elvisangelaccio moved this task from In progress to Under review on the Ark board.

elvisangelaccio closed this task as Resolved by committing R36:377dfcfebdd6: Fix crash when moving files with clizip.Oct 12 2016, 5:21 PM

elvisangelaccio added a commit: R36:377dfcfebdd6: Fix crash when moving files with clizip.