The patch provides save/restore mechanism for Tool Views panels. Current version produce random order at each start of KDevelop which seems to be "not right" behavior. New version provide save/restore mechanism, which uses Tool Views factory ids to store order - now it independent from current UI language. Also the patch adds new actions to Tool View context menu which provides simple way to change order.
Details
Details
- Reviewers
mwolff brauch - Group Reviewers
KDevelop - Commits
- R32:af272d38ed05: Save/Restore Tool Views order
R33:af272d38ed05: Save/Restore Tool Views order
Tested on master branch.
Diff Detail
Diff Detail
- Repository
- R33 KDevPlatform
- Branch
- Save/Restore_Tool_Views_order_(D3002)
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Wouldn't it be better to have some kind of drag&drop?
Yes, but I don't have good "drag&drop skills" :) Milian Wolff's answer (in mail list, 07.10.16):
If you think reordering is required, I'd implement it using drag'n'drop of the toolviews.
But Millian not react on this revision, maybe it has no free time for this :(
Comment Actions
+1 on the save/restore order part, that makes sense.
But I agree with Milian, if we want re-ordering (which I'm actually not sure about, I never felt the need for it), context menu actions are not the way to go. They are clunky to use and make the menu crowded.
Comment Actions
Nitpicks:
- some things could be const auto&, esp. in loops
- in my (and other people around kdev) preference, always write { } even for one line
Otherwise, +1, thanks!
Comment Actions
- some things could be const auto&, esp. in loops
- in my (and other people around kdev) preference, always write { } even for one line
Ok, fixed. I prefer {} for one-line loops, but in first revisions I tied to follow current style from source file.