Differential D2991

Fix moving windows to a different activity.
ClosedPublic
Actions

Authored by hein on Oct 9 2016, 10:12 AM.

Details

Reviewers
davidedmundson
mart
Group Reviewers
Plasma
Commits
R119:f169fb653566: Fix moving windows to a different activity.
Summary

BUG:370317

Diff Detail

Repository
R119 Plasma Desktop
Branch
Plasma/5.8
Lint
No Linters Available
Unit
No Unit Test Coverage
hein updated this revision to Diff 7224.Oct 9 2016, 10:12 AM
hein retitled this revision from to Fix moving windows to a different activity..
hein updated this object.
hein edited the test plan for this revision. (Show Details)
hein added reviewers: Plasma, davidedmundson.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 9 2016, 10:12 AM
davidedmundson edited edge metadata.Oct 9 2016, 12:21 PM

If a window is on activity A & B and a user drags a window from B to C should the activitity still be on A?

hein added a comment.Oct 9 2016, 12:26 PM

Not sure. This is what the old implementation did, which got lost due to a copy and paste error. I could see arguments for both behaviors (additive vs. exclusive). I don't use this functionality enough to know what users want. I'll ask in the bug ticket.

davidedmundson accepted this revision.Oct 9 2016, 12:47 PM
davidedmundson edited edge metadata.
This revision is now accepted and ready to land.Oct 9 2016, 12:47 PM
mart added a subscriber: mart.Oct 9 2016, 2:29 PM

in the old one iirc it moved the window

hein updated this revision to Diff 7244.Oct 10 2016, 9:22 AM
hein edited edge metadata.

Remove window from current activity, then add the target activity;
keep any other activities.

hein updated this revision to Diff 7245.Oct 10 2016, 9:34 AM

Remove source activity id instead of current activity.

Fixes drags originating from an activity delegate other than
the one for the current activity.

hein updated this revision to Diff 7246.Oct 10 2016, 9:56 AM

Use KWindowSystem instead of NetWinInfo.

More sanity checking.

Fix drop originating outside applet.

hein requested a review of this revision.Oct 10 2016, 10:04 AM
hein edited edge metadata.
mart accepted this revision.Oct 10 2016, 10:10 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Oct 10 2016, 10:10 AM
Closed by commit R119:f169fb653566: Fix moving windows to a different activity. (authored by hein). · Explain WhyOct 10 2016, 10:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7245

View Options

applets/pager/plugin/pagermodel.cpp

Loading...