Differential D29722

[sendlater] Use the new agent DBus call to save SendLater information
ClosedPublic
Actions

Authored by dvratil on May 13 2020, 4:28 PM.

Details

Reviewers

mlaurent

Maniphest Tasks

T13172: kdepim-apps-libs cleanup

Commits

R94:5d2765282978: [sendlater] Use the new agent DBus call to save SendLater information

Summary

Rather than using a shared library from kdepim-apps-libs, we use DBus to
talk to the agent. This ultimately allows us to kill the dedicated
libKF5SendLater library.

This also moves some pieces of the libKF5SendLater library that are used
in MessageComposer public API into MessageComposer library.

Diff Detail

Repository

R94 PIM: Message Library

Branch

sendlater-refactor

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26883
Build 26901: arc lint + arc unit

dvratil created this revision.May 13 2020, 4:28 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 13 2020, 4:28 PM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

dvratil requested review of this revision.May 13 2020, 4:28 PM

Harbormaster completed remote builds in B26858: Diff 82767.May 13 2020, 4:28 PM

dvratil added a dependent revision: D29723: Adapt KMail to MessageComposer SendLater API changes.May 13 2020, 4:31 PM

dvratil added a dependent revision: D29724: SendLaterAgent: merge libKF5SendLater library into the agent.May 13 2020, 4:36 PM

Increase messagelib version

This revision now requires changes to proceed.May 13 2020, 6:35 PM

Increase messagelib version

Harbormaster completed remote builds in B26883: Diff 82811.May 14 2020, 6:12 AM

mlaurent accepted this revision.May 15 2020, 4:52 AM

This revision is now accepted and ready to land.May 15 2020, 4:52 AM

dvratil closed this revision.May 19 2020, 8:22 AM

dvratil added a task: T13172: kdepim-apps-libs cleanup.May 19 2020, 9:17 AM

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (2 lines)
M		messagecomposer/autotests/CMakeLists.txt (4 lines)
A	M	messagecomposer/autotests/sendlaterdialogtest.h (36 lines)
A	M	messagecomposer/autotests/sendlaterdialogtest.cpp (60 lines)
A	M	messagecomposer/autotests/sendlaterinfotest.h (38 lines)
A	M	messagecomposer/autotests/sendlaterinfotest.cpp (108 lines)
M		messagecomposer/src/CMakeLists.txt (32 lines)
M		messagecomposer/src/composer/composerviewbase.h (12 lines)
M		messagecomposer/src/composer/composerviewbase.cpp (32 lines)
A	M	messagecomposer/src/sendlater/org.freedesktop.Akonadi.SendLaterAgent.xml (28 lines)
A	M	messagecomposer/src/sendlater/sendlatercreatejob.h (45 lines)
A	M	messagecomposer/src/sendlater/sendlatercreatejob.cpp (41 lines)
A	M	messagecomposer/src/sendlater/sendlaterdialog.h (74 lines)
A	M	messagecomposer/src/sendlater/sendlaterdialog.cpp (159 lines)
A	M	messagecomposer/src/sendlater/sendlaterinfo.h (89 lines)
A	M	messagecomposer/src/sendlater/sendlaterinfo.cpp (132 lines)
A	M	messagecomposer/src/sendlater/sendlaterjob.h (52 lines)
A	M	messagecomposer/src/sendlater/sendlaterjob.cpp (69 lines)
A	M	messagecomposer/src/sendlater/sendlaterremovejob.h (46 lines)
A	M	messagecomposer/src/sendlater/sendlaterremovejob.cpp (40 lines)
A	M	messagecomposer/src/sendlater/sendlatertimedatewidget.cpp (78 lines)
A	M	messagecomposer/src/sendlater/sendlatertimedatewidget_p.h (53 lines)
A	M	messagecomposer/src/sendlater/sendlaterutil.h (39 lines)
A	M	messagecomposer/src/sendlater/sendlaterutil.cpp (52 lines)
A	M	messagecomposer/src/sendlater/sendlaterutil_p.h (37 lines)
A	M	messagecomposer/src/sendlater/ui/sendlaterwidget.ui (67 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82767	562c4ad		May 13 2020, 4:28 PM	★	★
Diff 2	82811	562c4ad	* Increase messagelib version	May 14 2020, 6:12 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
391b09429c9e	f5ad5123195b	562c4ad46ba8	Daniel Vrátil	[sendlater] Use the new agent DBus call to save SendLater information (Show More…)	May 11 2020, 1:25 PM

Status	Author	Revision
Closed	dvratil	D29724 SendLaterAgent: merge libKF5SendLater library into the agent
Closed	dvratil	D29723 Adapt KMail to MessageComposer SendLater API changes
Closed	dvratil	D29722 [sendlater] Use the new agent DBus call to save SendLater information