Differential D29695

Add an internal guider calibration plot
ClosedPublic
Actions

Authored by murveit on May 12 2020, 9:40 PM.

Details

Reviewers

mutlaqja

Commits

R321:f0f7c658bbfe: Add an internal guider calibration plot

Summary

It plots the calibration samples, and displays a calibration status message.

Test Plan

New functionality. Run the internal guider with the simulator.
You can vary the number of iterations used in calibration via the guider parameters.
Click on the new calibration plot (just next to the drift plot)
and you should see updated sample points as calibration points are sampled.
Note, there is a delay at the start when the guide star is being selected.

Diff Detail

Repository

R321 KStars

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

murveit created this revision.May 12 2020, 9:40 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 12 2020, 9:40 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

murveit requested review of this revision.May 12 2020, 9:40 PM

Harbormaster completed remote builds in B26811: Diff 82699.May 12 2020, 9:40 PM

Lovely! Is there a reason the colors for RA/DE are not the same in Drift graphics?

Changed the colors for the "out" segments to match the colors in the drift graphics

Also now the auto-resize button moves the calibration plot back to its default -10,10 range.

Harbormaster completed remote builds in B26812: Diff 82701.May 12 2020, 10:10 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 13 2020, 2:10 PM

Closed by commit R321:f0f7c658bbfe: Add an internal guider calibration plot (authored by murveit, committed by mutlaqja). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kstars/ekos/guide/guide.h (9 lines)
M			kstars/ekos/guide/guide.cpp (173 lines)
M			kstars/ekos/guide/guide.ui (37 lines)
M			kstars/ekos/guide/guideinterface.h (11 lines)
M			kstars/ekos/guide/internalguide/internalguider.cpp (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82699	db21d04		May 12 2020, 9:40 PM	★	★
Diff 2	82701	db21d04	Changed the colors for the "out" segments to match the colors in the drift…	May 12 2020, 10:10 PM	★	★
Diff 3	82740	6a551dc	R321:f0f7c658bbfe65fbf653f214d82bfdf34d3463d5	May 13 2020, 2:10 PM	★	★