In D2967#55135, @davidedmundson wrote:

m_desktopContainments.remove(id);

should not be here.

why not? m_desktopContainments is a QHash<QString, QSet<Plasma::Containment *> > indexed by activity, if i don't update it manually here, it will stay full of dangling stuff..

But it also tracks them and deletes when an object is removed:
ShellCorona::desktopContainmentDestroyed

If you manually do it as well you're throwing all sense of a design pattern out the window and having it sometimes update the list before removal, sometimes after. Inconsistencies lead to bugs.

In D2967#55233, @davidedmundson wrote:

But it also tracks them and deletes when an object is removed:
ShellCorona::desktopContainmentDestroyed

If you manually do it as well you're throwing all sense of a design pattern out the window and having it sometimes update the list before removal, sometimes after. Inconsistencies lead to bugs.

ugh, i didn't remember that (that's what reviews are for, eh ;) fixed now