Differential D29572

Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT
ClosedPublic
Actions

Authored by kossebau on May 9 2020, 7:01 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R309:c8c10b76931a: Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT
Summary

To also support EXCLUDE_DEPRECATED_BEFORE_AND_AT=5.69.0 properly some
more if-elif would have been needed, making the code more hard to read.
Based on dicussion on #kde-devel with dfaure that has been left out,
for some future non-version-based *_BUILD_DEPRECATED.
So the focus already is on building without any own deprecated API,
no-one is expected to use EXCLUDE_DEPRECATED_BEFORE_AND_AT with a
certain version != CURREENT or 0.

Test Plan

Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0 (default) or CURRENT,
all unit tests pass.

Diff Detail

Repository
R309 KService
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.May 9 2020, 7:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 9 2020, 7:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.May 9 2020, 7:01 PM
dfaure accepted this revision.May 9 2020, 8:03 PM

Thanks!

This revision is now accepted and ready to land.May 9 2020, 8:03 PM
Closed by commit R309:c8c10b76931a: Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT (authored by kossebau). · Explain WhyMay 9 2020, 11:33 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 12 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 82403