Qt'fy access to pimpl objects: use macros Q_DECLARE_PRIVATE & Q_D
ClosedPublic
Actions

Authored by kossebau on Oct 5 2016, 11:35 PM.

Details

Reviewers

nienhueser

Group Reviewers

Marble

Commits

Summary

enforces constness some more (see issue spotted with GeoDataTrack::extendedData())
delivers inline-ness of the access methods
code should be more familiar to Qt developers

Repository

R34 Marble

Branch

qtifyPimplCode

Lint

No Linters Available

Unit

No Unit Test Coverage

kossebau retitled this revision from to Qt'fy access to pimpl objects: use macros Q_DECLARE_PRIVATE & Q_D.

kossebau updated this object.

kossebau added a reviewer: Marble.

Looks great, please push.

This revision is now accepted and ready to land.Oct 6 2016, 6:08 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/lib/marble/geodata/data/GeoDataGeometry.h (2 lines)
M			src/lib/marble/geodata/data/GeoDataGeometry.cpp (62 lines)
M			src/lib/marble/geodata/data/GeoDataLineString.h (3 lines)
M			src/lib/marble/geodata/data/GeoDataLineString.cpp (201 lines)
M			src/lib/marble/geodata/data/GeoDataModel.h (2 lines)
M			src/lib/marble/geodata/data/GeoDataModel.cpp (102 lines)
M			src/lib/marble/geodata/data/GeoDataMultiGeometry.h (4 lines)
M			src/lib/marble/geodata/data/GeoDataMultiGeometry.cpp (126 lines)
M			src/lib/marble/geodata/data/GeoDataMultiTrack.h (4 lines)
M			src/lib/marble/geodata/data/GeoDataMultiTrack.cpp (131 lines)
M			src/lib/marble/geodata/data/GeoDataPoint.h (4 lines)
M			src/lib/marble/geodata/data/GeoDataPoint.cpp (45 lines)
M			src/lib/marble/geodata/data/GeoDataPolygon.h (3 lines)
M			src/lib/marble/geodata/data/GeoDataPolygon.cpp (92 lines)
M			src/lib/marble/geodata/data/GeoDataTrack.h (5 lines)
M			src/lib/marble/geodata/data/GeoDataTrack.cpp (165 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7125	92e6692		Oct 5 2016, 11:35 PM	★	★
Diff 2	7168	92e6692	rMARBLE3e280f9061d48eeeb97a29e213d6931a88dbd53e	Oct 6 2016, 8:13 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
b2e6b1c7ad1c	eb0847d6910f	92e6692ca703	Friedrich W. H. Kossebau	Qt'fy access to pimpl objects: use macros Q_DECLARE_PRIVATE & Q_D (Show More…)	Oct 5 2016, 11:10 PM