Qt'fy access to pimpl objects: use macros Q_DECLARE_PRIVATE & Q_D
ClosedPublic

Authored by kossebau on Oct 5 2016, 11:35 PM.

Details

Summary
  • enforces constness some more (see issue spotted with GeoDataTrack::extendedData())
  • delivers inline-ness of the access methods
  • code should be more familiar to Qt developers

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 7125.Oct 5 2016, 11:35 PM
kossebau retitled this revision from to Qt'fy access to pimpl objects: use macros Q_DECLARE_PRIVATE & Q_D.
kossebau updated this object.
kossebau added a reviewer: Marble.
nienhueser accepted this revision.Oct 6 2016, 6:08 PM
nienhueser added a reviewer: nienhueser.
nienhueser added a subscriber: nienhueser.

Looks great, please push.

This revision is now accepted and ready to land.Oct 6 2016, 6:08 PM
This revision was automatically updated to reflect the committed changes.