Fix blurry icons by adding UseHighDpiPixmaps flag
AcceptedPublic

Authored by mthw on May 4 2020, 4:01 PM.

Details

Reviewers
asemke
sirgienko
Group Reviewers
Cantor
Summary

When using fractional scaling, icons on the top are blurred. This patch fixes the issue.
The only change needed to the code is to find a better placement for the line.

Test Plan

No side effects.

Before:


After:

Diff Detail

Repository
R55 Cantor
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26373
Build 26391: arc lint + arc unit
mthw created this revision.May 4 2020, 4:01 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 4 2020, 4:01 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
mthw requested review of this revision.May 4 2020, 4:01 PM
mthw added a reviewer: Cantor.May 4 2020, 4:01 PM
mthw edited the test plan for this revision. (Show Details)May 4 2020, 4:07 PM
asemke accepted this revision.May 4 2020, 8:13 PM
asemke added a subscriber: asemke.
asemke added inline comments.
src/main.cpp
45

having it here is ok.

This revision is now accepted and ready to land.May 4 2020, 8:13 PM
sirgienko added inline comments.
src/main.cpp
45

I think, better replace this TODO comment via comment about problem, which this flag solve and url to this revision, IMHO.

mthw updated this revision to Diff 81983.May 5 2020, 10:02 AM

Change comment

sirgienko accepted this revision.May 5 2020, 10:22 AM
mthw added a comment.Tue, May 5, 10:52 AM

If everything is fine, can someone land this, please? Also, could this also go into 20.04?

asemke added a comment.Tue, May 5, 1:21 PM
In D29417#663884, @mthw wrote:

If everything is fine, can someone land this, please? Also, could this also go into 20.04?

yes, this can also go into 20.04. We'll land it. Thanks.