Add autofocus tests.
Changes PlannedPublic

Authored by TallFurryMan on May 4 2020, 11:54 AM.



This differential adds autofocus tests using the Simulator profile.
This differential also uses the dbus variable "ekosState" to determine device connection (UI connection feedback will be implemented based on this test).
The connection/disconnection loops 20 times to verify no crash occurs during that sequence.

Test Plan

Execute "kstars_ui_tests".
1/ Check the connection/disconnection test succeeds.
2/ Check the autofocus convergence for each method.

Diff Detail

R321 KStars
improve__test_autofocus (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 26316
Build 26334: arc lint + arc unit
TallFurryMan created this revision.May 4 2020, 11:54 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMay 4 2020, 11:54 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.May 4 2020, 11:54 AM
TallFurryMan planned changes to this revision.May 4 2020, 11:58 AM

This differential is not finished yet. @mutlaqja please use it to test your changes with regards to INDI property usage.

Without your latest changes, the test fails while getting the state of INDI properties.
With your latest changes, the test fails, and it appears the INDI client is still busy sending stuff to the server when its references are removed.

So it's not working yet, but the situation is slightly different (better?). It takes a dozen of loops to crash, but the test is talking to a local server here, possibly more reactive compared to a remote one (however, no clue if a remote server would worsen things).

@mutlaqja I debugged the last connect/disconnect issue of BaseClient to be a sigpipe exception. I'll file the fix with this differential.

Actually, the fix for sigpipe would potentially be in INDI's baseclient.cpp...