[Wallpaper Configuration] Reword inline message concerning widget locking
ClosedPublic

Authored by filipf on May 2 2020, 8:12 PM.

Details

Summary

Widget locking is now only a hidden parameter that can be set up as a restriction so we're rewording the inline message to take that into account.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.May 2 2020, 8:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 2 2020, 8:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.May 2 2020, 8:12 PM
ngraham added a subscriber: ngraham.May 2 2020, 9:17 PM

Technically it still does exist, it's just hidden. If a person does enable this, perhaps the message is still nice to have? Or maybe we should not show it because the expectation would be that your admin/technically competent grandson has enabled it for your own good and this shouldn't be highlighted?

Technically it still does exist, it's just hidden. If a person does enable this, perhaps the message is still nice to have? Or maybe we should not show it because the expectation would be that your admin/technically competent grandson has enabled it for your own good and this shouldn't be highlighted?

Hmm if it still exists then we probably want to leave it because it doesn't make not being able to change the desktop layout look like a bug. How to enable widget locking currently though?

You need to set it in the config file by hand IIRC. It's quite hidden now, and will inevitably bit-rot. :/ I wonder if we should just bite the bullet and fully kill it, or expose a super hidden GUI for it somewhere,

filipf added a comment.May 3 2020, 7:32 AM

Ok, so the message can indeed still be turned on.

Setting:
~/.config/plasmarc [General] immutability=2 (or 4)

... does not work, however the following does:

~/.config/kdeglobals [KDE Action Restrictions][$i] plasma/plasmashell/unlockedDesktop=false

Which means that if widget locking now only exists as a restriction... perhaps it would make more sense to change the text of this inline message to say "Layout changes have been restricted by the system administrator"?
Otherwise telling a restricted user that widgets are locked isn't helpful since they can't (and shouldn't) unlock their widgets?

mart added a subscriber: mart.May 4 2020, 9:18 AM

Ok, so the message can indeed still be turned on.

Setting:
~/.config/plasmarc [General] immutability=2 (or 4)

... does not work, however the following does:

~/.config/kdeglobals [KDE Action Restrictions][$i] plasma/plasmashell/unlockedDesktop=false

Which means that if widget locking now only exists as a restriction... perhaps it would make more sense to change the text of this inline message to say "Layout changes have been restricted by the system administrator"?

yeah, +1 for that

filipf updated this revision to Diff 81911.May 4 2020, 3:40 PM

restore the inline message but change its text to note that layout changes have been restricted by the sysadmin

filipf retitled this revision from [Wallpaper Configuration] Remove obsolete inline message concerning widget locking to [Wallpaper Configuration] Reword inline message concerning widget locking.May 4 2020, 3:42 PM
filipf edited the summary of this revision. (Show Details)
ngraham accepted this revision.May 4 2020, 4:26 PM
This revision is now accepted and ready to land.May 4 2020, 4:26 PM
This revision was automatically updated to reflect the committed changes.