purpose is a runtime dependency, do not conditional on it at build time
ClosedPublic
Actions

Authored by sitter on Oct 4 2016, 10:38 AM.

Details

Reviewers

apol

Commits

Repository

R114 Plasma Addons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sitter retitled this revision from to purpose is a runtime dependency, do not conditional on it at build time.

sitter updated this object.

sitter edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

drop excess change

apol added a reviewer: apol.

This revision is now accepted and ready to land.Oct 4 2016, 11:16 AM

This revision was automatically updated to reflect the committed changes.

wouldn't that ensure that no distribution would ever bother to package purpose?

They have to package purpose since quickshare will have a broken runtime dependency (also spectacle is crippled without) :P

			Path	Packages
M			applets/CMakeLists.txt (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7080	ca66bf9		Oct 4 2016, 10:38 AM	★	★
Diff 2	7081	ca66bf9	drop excess change	Oct 4 2016, 10:39 AM	★	★
Diff 3	7082	ca66bf9	rKDEPLASMAADDONS3242dd0280da3f335a5039cbdf6e8359cef50e9b	Oct 4 2016, 11:27 AM	★	★