Differential D29297

[Notifications] Have checkIndex check if the index is valid
ClosedPublic
Actions

Authored by broulik on Apr 30 2020, 1:56 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:f2e34dbbd3b9: [Notifications] Have checkIndex check if the index is valid
Summary

Apparently by default it only considers "out of range" indices invalid but an invalid one as valid.

Test Plan

5.18?

  • Closing notifications still works
  • Pausing, aborting jobs still works

Possibly fixes Bug 418347 or some other unexpected crashers?
Maybe also fixes the crash I had in D27129

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 30 2020, 1:56 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 30 2020, 1:56 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 30 2020, 1:56 PM
broulik edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.May 1 2020, 2:59 PM
This revision is now accepted and ready to land.May 1 2020, 2:59 PM
Closed by commit R120:f2e34dbbd3b9: [Notifications] Have checkIndex check if the index is valid (authored by broulik). · Explain WhyMay 1 2020, 4:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81697

View Options

libnotificationmanager/jobsmodel.cpp

Loading...
View Options

libnotificationmanager/notificationsmodel.cpp

Loading...