Set better default and minimum sizes for the desktop config window
AbandonedPublic

Authored by ngraham on Apr 28 2020, 4:46 PM.

Details

Reviewers
None
Group Reviewers
VDG
Plasma
Summary

The desktop config window's sizing code is currently set in multiple places, with minimum
and default sizes that are too low to be useful. Every time I watch a YouTube video of someone
using Plasma and they change the wallpaper, the very first thing they do with this window
is make it bigger.

This patch fixes those issues.

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Branch
fix-desktop-config-window-initial-size (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26039
Build 26057: arc lint + arc unit
ngraham created this revision.Apr 28 2020, 4:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 28 2020, 4:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 28 2020, 4:46 PM
trmdi added a subscriber: trmdi.Apr 28 2020, 5:02 PM

Please keep in mind that not everyone uses a high res screen. 1366x768 is a very popular one, please don't make it too big on those screens. :(

GridUnit * 40 works out to be 720 px high with the default 10pt Noto Sans font, which is enough space to not interfere with the default 36px bottom panel.

But there's no way around the fact that this window greatly benefits from more space. On such a small screen resolution, I would expect people to want to just maximize the window.

trmdi added a comment.Apr 28 2020, 5:08 PM

GridUnit * 40 works out to be 720 px high with the default 10pt Noto Sans font, which is enough space to not interfere with the default 36px bottom panel.

But there's no way around the fact that this window greatly benefits from more space. On such a small screen resolution, I would expect people to want to just maximize the window.

Can the thumbnails be smaller instead? That always looks much better on small screens.
Maximize this window is a weird thing, because it's very difficult to see the new wallpaper.

I don't think it makes sense to make the thumbnails smaller. They're already quite small IMO and I often find myself wishing they were bigger!

In the end, a low-resolution screen is always gonna be a low-resolution screen.

Keep in mind that this patch doesn't impose a larger minimum size, just a larger default size.

Which reminds me, I shouldn't have removed the minimum size.

ngraham updated this revision to Diff 81446.Apr 28 2020, 5:28 PM

Restore minimum size, but make it sensible (previous minimum size made the window unusably small)

ngraham retitled this revision from Clean up desktop config window size code and set a better default size to Set better default and minimum sizes for the desktop config window.Apr 28 2020, 5:30 PM
ngraham edited the summary of this revision. (Show Details)
ngraham abandoned this revision.Apr 29 2020, 1:36 PM

This isn't the right solution as it affects all applet config windows, not just the wallpaper one. Sorry about the noise.