Differential D29249

Use deprecated QProcess::start() overload
AbandonedPublic
Actions

Authored by zzag on Apr 28 2020, 8:13 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Summary

In order to use QProcess::setProgram() we need to split the command into
a list of tokens. Unfortunately, the relevant method had been introduced
only in Qt 5.15.

In order to avoid regressions, this change partially reverts cca0e15b45.

Test Plan

dbus-run-session kwin_wayland "kate foo.txt" works again.

Diff Detail

Repository
R108 KWin
Branch
showfps-correct-timestamp
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26019
Build 26037: arc lint + arc unit
zzag created this revision.Apr 28 2020, 8:13 AM
Restricted Application added a project: KWin. · View Herald TranscriptApr 28 2020, 8:13 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Apr 28 2020, 8:13 AM
davidedmundson accepted this revision.Apr 28 2020, 9:27 AM
davidedmundson added a subscriber: davidedmundson.

If you want something non-deprecated KProcess might be worth looking into.
It's a QProcess wrapper that exists for handling multiple args properly.

This revision is now accepted and ready to land.Apr 28 2020, 9:27 AM
apol added a subscriber: apol.Apr 28 2020, 10:43 AM
apol added inline comments.
main_wayland.cpp
261

You can use KShell::splitArgs().

zzag abandoned this revision.Apr 28 2020, 12:21 PM

I'll submit a patch that uses KShell::splitArgs().

main_wayland.cpp
261

Thanks. I didn't know about it. :/

zzag added inline comments.Apr 28 2020, 12:55 PM
main_wayland.cpp
261

D29253

Revision Contents
Changeset List

PathPackages
Mmain_wayland.cpp (12 lines)

Diff 81416

View Options

main_wayland.cpp

Loading...