Select design or text view mode for new items
ClosedPublic
Actions

Authored by jfita on Apr 27 2020, 10:55 PM.

Details

Reviewers

staniek
piggz

Commits

R71:869b20b73da8: Select design or text view mode for new items

Summary

This is mainly for scripts: they do not support design view and, when
trying to create a new script it failed, with “!window, switching to
view mode failed, "Design View"” because KexiMainWindow always opened
new items with that mode.

I tried to create new items of all types and they seem to work, as the
only that did not like design mode was scripts.

However, i wonder if KexiParts should not have a “new item mode”
attribute or something similar to avoid hard coding it in
KexiMainWindow.

FIXED-IN:3.2.1

Diff Detail

Repository

R71 Kexi

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

jfita created this revision.Apr 27 2020, 10:55 PM

Restricted Application added a project: KEXI. · View Herald TranscriptApr 27 2020, 10:55 PM

Restricted Application added a subscriber: Kexi-Devel-list. · View Herald Transcript

jfita requested review of this revision.Apr 27 2020, 10:55 PM

Harbormaster completed remote builds in B26012: Diff 81407.Apr 27 2020, 10:55 PM

The fall back to text mode is correct and can help to manage consistency. kexi_scriptplugin.desktop vs kexi_tableplugin.desktop has only X-KDE-ServiceTypes=Kexi/Editor defined.

(Please note that scripting is experimental and is subject for rework, not sure if javascript is feasible, maybe python? Many apps turned to python and it's proved both for Krita and Blender.)

staniek accepted this revision.May 3 2020, 6:25 PM

This revision is now accepted and ready to land.May 3 2020, 6:25 PM

Closed by commit R71:869b20b73da8: Select design or text view mode for new items (authored by jfita, committed by staniek). · Explain WhyMay 3 2020, 6:28 PM

This revision was automatically updated to reflect the committed changes.