Fix bug where tab fitsviews weren't receiving images when fitsviewer was not enabled
ClosedPublic

Authored by murveit on Apr 26 2020, 10:08 PM.

Details

Summary

The bug is described in https://indilib.org/forum/ekos/6756-re-problems-with-focus-module-images-not-coming-in.html?start=36#52722
though I actually don't think the particular technique to trigger autofocus matters.
What matters is that fitsviewer is not enabled in the KSTARS FITS settings (not mentioned in that particular thread post).
There was a test for not displaying if fitsviewer was not enabled, but it should have added "but only for NORMAL or CALIBRATION images"
as the other kinds of images have their own private fitsview. There is further complication with batch mode.

Test Plan

Repeat procedure described in the above forum thread and importantly also disable fitsviewer in the KSTARS FITS options.
Without this fix, the manual focus procedure works, but the automated (after 1 minute) autofocus should get the same
number of stars and HFR calculation for each input image. With this fix, the #stars and HFRs should vary as normal.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
murveit created this revision.Apr 26 2020, 10:08 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 26 2020, 10:08 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
murveit requested review of this revision.Apr 26 2020, 10:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2020, 7:04 AM
This revision was automatically updated to reflect the committed changes.