diff --git a/kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml b/kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml --- a/kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml +++ b/kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml @@ -32,11 +32,11 @@ //TODO: After KF5 (qqc2-desktop-style) depends on Qt 5.15 this can be simplified using newer API // (https://bugs.kde.org/show_bug.cgi?id=419521) // valueRole: "value" - property var currentValue + property var activeValue onActivated: (index) => { var modelIndex = model.index(index, 0); - currentValue = model.data(modelIndex, Qt.UserRole); + activeValue = model.data(modelIndex, Qt.UserRole); } property bool multipleChoice: false diff --git a/kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml b/kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml --- a/kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml +++ b/kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml @@ -77,7 +77,7 @@ model: policyModel onActivated: { - policy = currentValue; + policy = activeValue; } } diff --git a/kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml b/kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml --- a/kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml +++ b/kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml @@ -106,7 +106,7 @@ flat: true model: ruleOptions onActivated: (index) => { - valueEditor.valueEdited(currentValue); + valueEditor.valueEdited(activeValue); } } } diff --git a/kcmkwin/kwinrules/rulesdialog.cpp b/kcmkwin/kwinrules/rulesdialog.cpp --- a/kcmkwin/kwinrules/rulesdialog.cpp +++ b/kcmkwin/kwinrules/rulesdialog.cpp @@ -47,10 +47,8 @@ QStandardPaths::GenericDataLocation, QStringLiteral("kpackage/kcms/kcm_kwinrules/contents/ui/RulesEditor.qml")))); quickView->setResizeMode(QQuickView::SizeRootObjectToView); - if (quickView-> status != QQuickView::Ready) { - qDebug() << quickView->errors(); - QDialog::reject(); - + if (quickView->status() != QQuickView::Ready) { + qFatal("Could not load rules dialog"); return; }