Differential D29127

Account for top and bottom margin in default card height
ClosedPublic
Actions

Authored by ahiemstra on Apr 23 2020, 10:15 AM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:a9c8cb612992: Account for top and bottom margin in default card height
Summary

This makes Card account for the negative top and bottom margin when used
in its default Banner height. In addition, only add top and bottom
padding when there is a content item. This ensures that cards without
contents have a correct default height that doesn't leave any gaps at
the bottom.

Most prominently, this removes the need for any height specification in
the new Kirigami Gallery main page and fixes the cards' height when
displaying only one column.

Test Plan

All cards in Kirigami Gallery display correctly now.

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahiemstra created this revision.Apr 23 2020, 10:15 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 23 2020, 10:15 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ahiemstra requested review of this revision.Apr 23 2020, 10:15 AM
mart accepted this revision.Apr 23 2020, 10:23 AM
This revision is now accepted and ready to land.Apr 23 2020, 10:23 AM
Closed by commit R169:a9c8cb612992: Account for top and bottom margin in default card height (authored by ahiemstra). · Explain WhyApr 23 2020, 10:29 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 80979