Remove duplicated code
AbandonedPublic
Actions

Authored by apol on Apr 21 2020, 12:22 AM.

Details

Reviewers

zzag

Group Reviewers

Frameworks

Summary

Went through it while reviewing some code.

Test Plan

Been running it for a while, including direct testing of the code while investigating something else

Repository

R130 Frameworks integration plugin using KWayland

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25568
Build 25586: arc lint + arc unit

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

apol requested review of this revision.Apr 21 2020, 12:22 AM

zzag requested changes to this revision.Apr 21 2020, 12:53 PM

zzag added a subscriber: zzag.

zzag added inline comments.

src/windowsystem/waylandintegration.cpp
191	The old and the new code are not the same. With f(), we're going to emit windowRemoved() instead of windowAdded().

This revision now requires changes to proceed.Apr 21 2020, 12:53 PM

My bad, thanks!

			Path	Packages
M			src/windowsystem/waylandintegration.cpp (14 lines)

Commit	Tree	Parents	Author	Summary	Date
cf8749545409	f7d23be6fd0a	cb0380f77e33	Aleix Pol	Remove duplicated code (Show More…)	Apr 21 2020, 12:21 AM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80718	cb0380f		Apr 21 2020, 12:22 AM	★	★