Differential D2900

[Kickoff] Draw FrameSvgItem behind kickoff configuration buttons
ClosedPublic
Actions

Authored by jsalatas on Sep 30 2016, 8:57 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma: Design
Plasma
Commits
R119:f722ae242318: [Kickoff] Draw FrameSvgItem behind kickoff configuration buttons
Summary

This ensures we don't end up with a white icon (dark Plasma theme) on a light gray (default application colors) background. It also makes the configuration (draggable) buttons look more like a live preview.

similar to: https://phabricator.kde.org/D2884

Test Plan

Breeze dark application scheme, Breeze dark Plasma theme


Breeze dark application scheme, Breeze light Plasma theme

Breeze light application scheme, Breeze light Plasma theme

Breeze light application scheme, Breeze dark Plasma theme

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsalatas updated this revision to Diff 7012.Sep 30 2016, 8:57 PM
jsalatas retitled this revision from to [Kickoff] Draw FrameSvgItem behind kickoff configuration buttons.
jsalatas updated this object.
jsalatas edited the test plan for this revision. (Show Details)
jsalatas added a reviewer: Plasma.
jsalatas set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 30 2016, 8:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson added a subscriber: davidedmundson.Sep 30 2016, 9:03 PM
davidedmundson added inline comments.
applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml
30–38

You should be able to get rid of the Item {} and just use the FrameSvgItem for the root component

45

for the tabs the background will always be widgets/background they're not shown directly on the panel.

jsalatas updated this revision to Diff 7013.Sep 30 2016, 9:15 PM
jsalatas removed R119 Plasma Desktop as the repository for this revision.
davidedmundson accepted this revision.Sep 30 2016, 9:18 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Sep 30 2016, 9:18 PM
Closed by commit R119:f722ae242318: [Kickoff] Draw FrameSvgItem behind kickoff configuration buttons (authored by jsalatas, committed by davidedmundson). · Explain WhySep 30 2016, 9:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7014

View Options

applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml

Loading...