[Kickoff] Draw FrameSvg behind icon preview
ClosedPublic

Authored by broulik on Sep 29 2016, 9:18 AM.

Details

Summary

This ensures we don't end up with a white icon (dark Plasma theme) on a light gray (default application colors) background. It also makes the button look more like a live preview.

Test Plan

Breeze application scheme, Breeze dark Plasma theme, applet on desktop


Breeze application scheme, Breeze dark Plasma theme, applet in panel

Breeze application scheme, Breeze light Plasma theme, applet in panel

Breeze dark application scheme, Breeze light Plasma theme, applet in panel

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6982.Sep 29 2016, 9:18 AM
broulik retitled this revision from to [Kickoff] Draw FrameSvg behind icon preview.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 29 2016, 9:18 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Sep 29 2016, 9:18 AM
davidedmundson accepted this revision.Sep 29 2016, 9:22 AM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.

Nice

This revision is now accepted and ready to land.Sep 29 2016, 9:22 AM
mart accepted this revision.Sep 29 2016, 9:34 AM
mart added a reviewer: mart.
This revision was automatically updated to reflect the committed changes.