Differential D28949

Add titlebar colors to Kirigami::PlatformTheme
ClosedPublic
Actions

Authored by cblack on Apr 18 2020, 4:38 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Maniphest Tasks
T10201: Window titlebars
Commits
R169:0d5d94ebe086: Add titlebar colors to Kirigami::PlatformTheme
Summary

This is a prerequisite for implementing the tools area in QML applications, which requires having access to the titlbar colour.

Test Plan
import QtQuick 2.0
import org.kde.kirigami 2.12 as Kirigami

Rectangle {
    color: Kirigami.Theme.titlebarBackgroundColor
}

Diff Detail

Repository
R169 Kirigami
Branch
cblack/tools-area (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25426
Build 25444: arc lint + arc unit
cblack created this revision.Apr 18 2020, 4:38 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 18 2020, 4:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Apr 18 2020, 4:38 PM
mart added a subscriber: mart.Apr 20 2020, 4:11 PM

what's the "tools area"?
are there other use cases than client side decorations? (which we don't want to support)

mart accepted this revision.Apr 20 2020, 4:15 PM

ok, thanks for the clarification

This revision is now accepted and ready to land.Apr 20 2020, 4:15 PM
Closed by commit R169:0d5d94ebe086: Add titlebar colors to Kirigami::PlatformTheme (authored by cblack). · Explain WhyApr 20 2020, 9:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 80476

View Options

src/libkirigami/platformtheme.h

Loading...
View Options

src/libkirigami/platformtheme.cpp

Loading...