Add titlebar colors to Kirigami::PlatformTheme
ClosedPublic
Actions

Authored by cblack on Apr 18 2020, 4:38 PM.

Details

Reviewers

mart

Group Reviewers

Kirigami

Maniphest Tasks

T10201: Window titlebars

Commits

Summary

This is a prerequisite for implementing the tools area in QML applications, which requires having access to the titlbar colour.

Test Plan

import QtQuick 2.0
import org.kde.kirigami 2.12 as Kirigami

Rectangle {
    color: Kirigami.Theme.titlebarBackgroundColor
}

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

cblack requested review of this revision.Apr 18 2020, 4:38 PM

what's the "tools area"?
are there other use cases than client side decorations? (which we don't want to support)

ok, thanks for the clarification

This revision is now accepted and ready to land.Apr 20 2020, 4:15 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/libkirigami/platformtheme.h (23 lines)
M			src/libkirigami/platformtheme.cpp (107 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80476	57c63e7		Apr 18 2020, 4:38 PM	★	★
Diff 2	80708	f9d31fe	R169:0d5d94ebe0863f084cd72dcc3a138d6dbde490d7	Apr 20 2020, 9:37 PM	★	★