use SPDX identifiers for license and ensure that reuse tool is happy
ClosedPublic
Actions

Authored by mgallien on Apr 18 2020, 1:47 PM.

Details

Reviewers

ervin
ognarb

Commits

R197:a9c22e2e38d6: use SPDX identifiers for license and ensure that reuse tool is happy

Test Plan

reuse lint says that it is happy

Diff Detail

Repository

R197 Kairo

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Apr 18 2020, 1:47 PM

mgallien created this revision.

Harbormaster completed remote builds in B25418: Diff 80467.Apr 18 2020, 1:47 PM

ognarb added inline comments.Apr 18 2020, 2:37 PM

src/Dependencies.qml
4	I guess this is still recognized by reuse, but the correct notation should be `SPDX-FileCopyrightText: 2016 (c) Kevin Ottens <ervin@kde.org>`. `find * -type f -exec sed -i 's:Copyright 2016:SPDX-FileCopyrightText: 2016 (c):g' {} \;` should fix it (not tested).
src/android/AndroidManifest.xml.license
2	Here we have two years now. You should probably use `--year 2016 --copyright="(c) Kevin Ottens <ervin@kde.org>"` instead

ervin added inline comments.Apr 18 2020, 8:46 PM

.arcconfig.license
4	Rather clueless here, but shouldn't that be GPL-3.0-only ? Since it's the LicenseRef-KDE-Accepted-GPL part which describes which later GPL versions are allowed. Honest question I didn't quite dig up on the topic yet.

ognarb added inline comments.Apr 19 2020, 8:05 AM

.arcconfig.license
4	So acording to https://community.kde.org/Policies/Licensing_Policy it should be GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL.

Thanks for clarifying what I should have done. I will push a new version compliant with the KDE policy.

update thanks to the review

Harbormaster completed remote builds in B25884: Diff 81181.Apr 25 2020, 4:44 PM

IANAL but this looks good :)

This revision is now accepted and ready to land.Apr 25 2020, 6:16 PM

Closed by commit R197:a9c22e2e38d6: use SPDX identifiers for license and ensure that reuse tool is happy (authored by mgallien). · Explain WhyApr 25 2020, 7:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	.arcconfig.license (3 lines)
A	M	.gitmodules.license (3 lines)
M		CMakeLists.txt (4 lines)
A	M	LICENSES/GPL-2.0-only.txt (319 lines)
A	M	LICENSES/GPL-3.0-only.txt (625 lines)
A	M	LICENSES/LicenseRef-KDE-Accepted-GPL.txt (13 lines)
M		src/CMakeLists.txt (4 lines)
M		src/CircuitControlPage.qml (19 lines)
M		src/CircuitListPage.qml (23 lines)
M		src/Dependencies.qml (8 lines)
A	M	src/android/AndroidManifest.xml.license (3 lines)
A	M	src/android/build.gradle.license (3 lines)
A	M	src/android/gradle/wrapper/gradle-wrapper.jar.license (3 lines)
A	M	src/android/gradle/wrapper/gradle-wrapper.properties.license (3 lines)
A	M	src/android/gradlew.license (3 lines)
A	M	src/android/res/values/libs.xml.license (3 lines)
M		src/circuitcontrol.h (23 lines)
M		src/circuitcontrol.cpp (23 lines)
M		src/circuitlistmodel.h (23 lines)
M		src/circuitlistmodel.cpp (23 lines)
M		src/circuitmodel.h (23 lines)
M		src/circuitmodel.cpp (19 lines)
M		src/circuitreader.h (23 lines)
M		src/circuitreader.cpp (23 lines)
A	M	src/endbeep.wav.license (3 lines)
M		src/kairo.pro (4 lines)
A	M	src/kirigami-icons.qrc.license (3 lines)
A	M	src/longbeep.wav.license (3 lines)
M		src/main.cpp (23 lines)
M		src/main.qml (19 lines)
A	M	src/main.qrc.license (3 lines)
A	M	src/shortbeep.wav.license (3 lines)
M		src/soundcontrol.h (23 lines)
M		src/soundcontrol.cpp (23 lines)
M		src/soundcontrolinterface.h (23 lines)
M		src/soundcontrolinterface.cpp (19 lines)
M		src/soundcontrolstub.h (23 lines)
M		src/soundcontrolstub.cpp (23 lines)
M		src/timercontrol.h (23 lines)
M		src/timercontrol.cpp (23 lines)
M		src/timermodel.h (19 lines)
M		src/timermodel.cpp (19 lines)
M		src/timernotificationcontrol.h (23 lines)
M		src/timernotificationcontrol.cpp (23 lines)
M		tests/CMakeLists.txt (4 lines)
M		tests/circuitcontroltest.cpp (23 lines)
M		tests/circuitlistmodeltest.cpp (23 lines)
M		tests/circuitmodeltest.cpp (23 lines)
M		tests/circuitreadertest.cpp (23 lines)
M		tests/timercontroltest.cpp (23 lines)
M		tests/timermodeltest.cpp (23 lines)
M		tests/timernotificationcontroltest.cpp (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	80467	34967b9		Apr 18 2020, 1:47 PM	★	★
Diff 2	81181	60672cc	update thanks to the review	Apr 25 2020, 4:44 PM	★	★
Diff 3	81194	60672cc	R197:a9c22e2e38d613f449968de964f80a3e51c49ae5	Apr 25 2020, 7:32 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
2da5a0fe034d	b507db96c186	60672cca158f	Matthieu Gallien	use SPDX identifiers for license and ensure that reuse tool is happy (Show More…)	Apr 18 2020, 1:42 PM