Differential D28937

EventViews::setResourceColor: modify the Akonadi::CollectionColorAttribute in the collection
ClosedPublic
Actions

Authored by dfaure on Apr 18 2020, 9:16 AM.

Details

Reviewers
dvratil
ochurlaud
Commits
R76:89938bdce6d6: EventViews::setResourceColor: modify the Akonadi::CollectionColorAttribute in…
Summary

This gives a chance to the resource to store the color server side
(implemented for DAV).

This commit improves upon D7500 (1ec2e08a83c0) which only implemented reading
from the attribute.

Test Plan

(after implementing saving in the dav resource) changing a calendar color
in korganizer now propagates to the server, F5 in roundcube and the new color appears.
This helps when using multiple computers, or when the dav resource temporarily forgets
about all folder (ahem).

Diff Detail

Repository
R76 PIM: Event Views
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25414
Build 25432: arc lint + arc unit
dfaure created this revision.Apr 18 2020, 9:16 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 18 2020, 9:16 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dfaure requested review of this revision.Apr 18 2020, 9:16 AM
dvratil requested changes to this revision.Apr 18 2020, 10:34 AM
dvratil added inline comments.
src/helper.cpp
62 ↗(On Diff #80450)

Missing parentheses

63 ↗(On Diff #80450)

Bad indentation, missing context (e.g. "Failed to set CollectionColorAttribute:" << job->errorString()) - just randomly printing an error message into a log without context is almost as useful as not having it at all :)

This revision now requires changes to proceed.Apr 18 2020, 10:34 AM
dfaure marked an inline comment as done.Apr 18 2020, 11:04 AM
dfaure added inline comments.
src/helper.cpp
63 ↗(On Diff #80450)

Not for people who use %{function} in $QT_MESSAGE_PATTERN :-)

dfaure updated this revision to Diff 80460.Apr 18 2020, 11:05 AM

Add {...} and more text to the warning

dvratil accepted this revision.Apr 18 2020, 12:07 PM
dvratil added inline comments.
src/helper.cpp
63 ↗(On Diff #80450)

I have it too but all I get is unknown - probably because of RelWithDebInfo..

This revision is now accepted and ready to land.Apr 18 2020, 12:07 PM
dfaure closed this revision.Apr 18 2020, 12:12 PM

Revision Contents
Changeset List

PathPackages
Msrc/helper.h (4 lines)
Msrc/helper.cpp (23 lines)

Diff 80460

View Options

src/helper.h

Loading...
View Options

src/helper.cpp

Loading...