Differential D28914

Include the Plasma Vault name in the mount dialog title
ClosedPublic
Actions

Authored by ksmanis on Apr 17 2020, 12:19 PM.

Details

Reviewers
davidedmundson
ivan
ngraham
Group Reviewers
Plasma
VDG
Commits
R845:6944aab19e86: Include the Plasma Vault name in the mount dialog title
Summary

Allows synergy with password managers that rely on the window title in order to supply the appropriate password.

Test Plan

Compiles and runs as expected both on master and Plasma/5.18 branches.

Diff Detail

Repository
R845 Plasma Vault
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ksmanis created this revision.Apr 17 2020, 12:19 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 17 2020, 12:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ksmanis requested review of this revision.Apr 17 2020, 12:19 PM
davidedmundson accepted this revision.Apr 17 2020, 2:59 PM
This revision is now accepted and ready to land.Apr 17 2020, 2:59 PM
ngraham added reviewers: ivan, VDG.Apr 17 2020, 3:14 PM
ngraham added a subscriber: ngraham.
ngraham added inline comments.
kded/ui/mountdialog.cpp
34

Maybe put the vault name in single quotes?

ngraham added a comment.Apr 17 2020, 3:15 PM

Can you provide your email address in a comment here so that we can land the patch with the correct git authorship information?

ksmanis added a comment.Apr 17 2020, 3:27 PM
In D28914#650523, @ngraham wrote:

Can you provide your email address in a comment here so that we can land the patch with the correct git authorship information?

I'd like to give arcanist a spin, if possible :)

ngraham added a comment.Apr 17 2020, 3:57 PM

Go ahead, although we're migrating patch review to GitLab in the coming weeks, so the benefit may be short-lived. :)

ksmanis updated this revision to Diff 80455.Apr 18 2020, 9:41 AM
  • Add single quotes around the vault name
ksmanis marked an inline comment as done.Apr 18 2020, 9:42 AM
ksmanis added inline comments.
kded/ui/mountdialog.cpp
34

Agreed, I had single quotes initially, but wasn't sure if it was proper.

ngraham accepted this revision.Apr 18 2020, 3:56 PM
Closed by commit R845:6944aab19e86: Include the Plasma Vault name in the mount dialog title (authored by ksmanis, committed by ngraham). · Explain WhyApr 19 2020, 4:51 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Apr 19 2020, 4:52 PM

Landed on master since adding or changing strings in the stable branch isn't allowed.

Thanks for the contribution!

Revision Contents
Changeset List

PathPackages
Mkded/ui/mountdialog.cpp (1 line)
Mkded/ui/mountdialog.ui (3 lines)

Diff 80560

View Options

kded/ui/mountdialog.cpp

Loading...
View Options

kded/ui/mountdialog.ui

Loading...