Nicaragua Holidays
ClosedPublic

Authored by carguello on Apr 16 2020, 9:11 PM.

Details

Reviewers
winterz
Group Reviewers
Frameworks
Commits
R175:97139b80e80b: Nicaragua Holidays
Summary

Added file containing Nicaragua holidays in holidays/plan2/holiday_ni_es

Diff Detail

Repository
R175 KHolidays
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
carguello created this revision.Apr 16 2020, 9:11 PM
Restricted Application added a project: Frameworks. Β· View Herald TranscriptApr 16 2020, 9:11 PM
Restricted Application added a subscriber: kde-frameworks-devel. Β· View Herald Transcript
carguello requested review of this revision.Apr 16 2020, 9:11 PM
ngraham added a subscriber: ngraham.

Thanks for the patch! You need to update the holidays/holidays.qrc file too, to mention this new file that you're adding. Also I don't think you need to have the .qrc extension on the file you're adding.

ngraham removed a reviewer: VDG.Apr 16 2020, 9:26 PM
carguello updated this revision to Diff 80318.Apr 16 2020, 9:38 PM

Remove file extension .qrc per instructions

I think I messed up πŸ˜”

carguello updated this revision to Diff 80319.Apr 16 2020, 9:44 PM

Previously messed up holidays/holidays.qrc I have fixed it now

Now the new file you wanted to add is gone. :)

With Phabricator, you need to include all commits in your patch, not just the latest one.

😢

How can I add it back? Sorry this is my first time using git and Phabricator

git add [the path to the new file you want to add]`
arc diff --update D28891
carguello updated this revision to Diff 80322.Apr 16 2020, 9:49 PM

Adding Nicaragua Holidays file back

Okay, I'm confident it went through this time

Great job! I'll hand it over to @winterz and other reviewers now.

Thank you for your time and support. πŸ™‚πŸ™‚

You're very welcome. Thank you for the patch!

winterz added inline comments.Apr 17 2020, 3:09 PM
holidays/holidays.qrc
101

realign the indentation

103

realign the indentation

winterz accepted this revision.Apr 17 2020, 6:56 PM

other than the indentation in the .qrc file this is good to go.. tests pass

would appreciate if someone would commit this for us. (after fixing the indentation)

This revision is now accepted and ready to land.Apr 17 2020, 6:56 PM
This revision was automatically updated to reflect the committed changes.