Differential D28851

Mark KStatusBarOfflineIndicator as deprecated
ClosedPublic
Actions

Authored by nicolasfella on Apr 15 2020, 11:40 AM.

Details

Reviewers

dfaure

Group Reviewers

Frameworks

Maniphest Tasks

T12373: Move or kill KStatusBarOfflineIndicator

Commits

R241:cd53f10cad27: Mark KStatusBarOfflineIndicator as deprecated

Summary

Conceptually it doesn't really belong to KIO and KTorrent was its only user. The code has been imported into KTorrent so we don't have any users left.

Test Plan

builds

Diff Detail

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Apr 15 2020, 11:40 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptApr 15 2020, 11:40 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Apr 15 2020, 11:40 AM

Harbormaster completed remote builds in B25267: Diff 80190.Apr 15 2020, 11:40 AM

nicolasfella added a task: T12373: Move or kill KStatusBarOfflineIndicator.Apr 15 2020, 11:49 AM

Yeah, it's from before Solid existed... KIO was the only place for this kind of stuff back then.

This revision is now accepted and ready to land.Apr 15 2020, 2:09 PM

Closed by commit R241:cd53f10cad27: Mark KStatusBarOfflineIndicator as deprecated (authored by nicolasfella). · Explain WhyApr 15 2020, 2:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/filewidgets/CMakeLists.txt (2 lines)
M			src/filewidgets/kstatusbarofflineindicator.h (7 lines)
M			src/filewidgets/kstatusbarofflineindicator.cpp (4 lines)