src/plugins/importexport/csv/kexicsvimportdialog.cpp
1403	@jkunert Does the change from exactMatch() to match() work OK? I thought we expect exact match here to parse complete number and nothing more. If there's something else and it's not a whitespace we would have an error. Similar case-by case check is needed in other uses of match() below.

staniek added inline comments.Sep 28 2016, 10:40 PM

src/widget/utils/kexidatetimeformatter.cpp
340	Thanks, that was a typo causing a defect of the formatter. We will need autotests for this code :)

jkunert added inline comments.Sep 29 2016, 9:12 AM

src/plugins/importexport/csv/kexicsvimportdialog.cpp
1403	My mistake. I will fix it.

BTW, Interesting finding that shows we've got not many testers on board (and we badly need so basic autotests):
"Input and display of Date/Time/Date Time values broken" -
https://bugs.kde.org/show_bug.cgi?id=369518

For a minute I thought it's related to the above issue with the patch but the breakage is unrelated.

jkunert mentioned this in D2888: T1767: Port QRegExp to QRegularExpression in Kexi.Sep 29 2016, 7:56 PM

jkunert added a dependent revision: D2888: T1767: Port QRegExp to QRegularExpression in Kexi.

Replaced by D2888

Revision Contents
Changeset List

			Path	Packages
M			src/formeditor/connectiondialog.cpp (10 lines)
M			src/kexiutils/completer/KexiCompleter.cpp (2 lines)
M			src/main/startup/KexiWelcomeStatusBar.cpp (13 lines)
M			src/plugins/importexport/csv/kexicsvimportdialog.h (4 lines)
M			src/plugins/importexport/csv/kexicsvimportdialog.cpp (35 lines)
M			src/plugins/queries/kexiquerydesignerguieditor.cpp (30 lines)
M			src/plugins/scripting/kexidb/kexidbschema.cpp (6 lines)
M			src/tests/altertable/altertable.cpp (8 lines)
M			src/widget/utils/kexidatetimeformatter.cpp (33 lines)