Port QRegExp to QRegularExpression in Kexi

Authored by staniek on Sep 28 2016, 10:34 PM.


Diff Detail

R71 Kexi
Lint Skipped
Unit Tests Skipped
staniek updated this revision to Diff 6978.Sep 28 2016, 10:34 PM
staniek retitled this revision from to Port QRegExp to QRegularExpression in Kexi.
staniek updated this object.
staniek edited the test plan for this revision. (Show Details)
staniek added a reviewer: piggz.
staniek set the repository for this revision to R71 Kexi.
staniek added a subscriber: jkunert.
Restricted Application added a project: KEXI. · View Herald TranscriptSep 28 2016, 10:34 PM
staniek added inline comments.Sep 28 2016, 10:38 PM

@jkunert Does the change from exactMatch() to match() work OK?
I thought we expect exact match here to parse complete number and nothing more. If there's something else and it's not a whitespace we would have an error.

Similar case-by case check is needed in other uses of match() below.

staniek added inline comments.Sep 28 2016, 10:40 PM

Thanks, that was a typo causing a defect of the formatter. We will need autotests for this code :)

jkunert added inline comments.Sep 29 2016, 9:12 AM

My mistake. I will fix it.

BTW, Interesting finding that shows we've got not many testers on board (and we badly need so basic autotests):
"Input and display of Date/Time/Date Time values broken" -

For a minute I thought it's related to the above issue with the patch but the breakage is unrelated.

staniek abandoned this revision.Sep 29 2016, 11:06 PM

Replaced by D2888