Fixes the mentioned bug by creating all necessary subdirectories.
BUG: 417722
Details
Details
- Reviewers
davidre ngraham - Group Reviewers
Spectacle - Commits
- R166:464dde9677f4: Fix inability to Drag+Drop screenshot due to subfolder in filename
- Set save Filename in Spectacle to one including one or more /, thus including subdirectories. Example: %Y/%M/screen-%2d
- Take a screenshot
- Start dragging the preview
Diff Detail
Diff Detail
- Repository
- R166 Spectacle
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I wonder why we care about subdirs at all? If we do tempSave for drag and drop would it be sufficient to create the file in the tmp dir and strip the rest of autosaveFilename? This would save the need to create the subdirectories but I don't think it will make a big difference either way, but it's one thing less that could fail?
Comment Actions
Stripping the filename of subdirs would be fine with me.
I did try to be consistent, just in case something may not work otherwise.
Is autosaveFilename.section(QDir::separator(), -1); fine or would you like to have QUrl::fileName() used for stripping?
| src/ExportManager.cpp | ||
|---|---|---|
| 403 | I did use QDir::separator() because it was used before for this and is used for constructing mTempDir at the beginning of the function (Line 395). | |
| 406 | ok, will fix. | |
| src/ExportManager.cpp | ||
|---|---|---|
| 403 | Probably. That's unrelated to this patch though, and should be fixed in another one. | |
Comment Actions
I decided to go with the suggested "just strip the subdirs".
The change is smaller and it should not matter for temporary saving.
The only other places tempSave() is used is for export via purpose and export via KIPI.
I tested some exports of both and they seemed to work fine either way.
Comment Actions
Nice patch.
Can you provide your name and email address so we can land it with correct git authorship information?
Comment Actions
I've updated my information on https://identity.kde.org/index.php?r=people/view&uid=brainpower , but this seems to have not propagated to the phabricator profile? (yet?)
Comment Actions
The two aren't linked, and I don't have the ability to see that page.
You can either tell me that information in a comment here, or else put in your .gitconfig file and submit patchs using arc; Phabricator ignores the git authorship information if you don't use arc, which is stupid, but since we're migrating to GitLab soon enough, we won't have to live with it for long. :)
Comment Actions
Well, the name is Franz Baumgärtner , mail is: f.baumg at mailbox dot org . (If the name has to be ascii, please use ae as replacement for the ä.)