Differential D28632

use the decoded url for launcherPosition
ClosedPublic
Actions

Authored by mart on Apr 6 2020, 6:16 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R120:627920bdfe14: use the decoded url for launcherPosition
R120:ac0124c48ce6: use the decoded url for launcherPosition
Summary

launchersOrder and the actual url data can be different:
in case of preferred:/ urls launcherorder will have that for
(for serialization) and the actual appdata url will be decoded as for
instance Applications:firefox.desktop.
this url is the one that needs to be compared to know the actual
launcher order

BUG:418483

Test Plan

firefox stays in first position when pinned as preferred://browser

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Apr 6 2020, 6:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 6 2020, 6:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Apr 6 2020, 6:16 PM
ngraham accepted this revision.Apr 6 2020, 6:27 PM
ngraham added a subscriber: ngraham.

This completely fixes the issue for me.

Stable branch, probably.

This revision is now accepted and ready to land.Apr 6 2020, 6:27 PM
Closed by commit R120:627920bdfe14: use the decoded url for launcherPosition (authored by mart). · Explain WhyApr 6 2020, 6:30 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Apr 6 2020, 6:48 PM

Not Plasma/5.18?

Revision Contents
Changeset List

Diff 79518

View Options

libtaskmanager/launchertasksmodel.cpp

Loading...