Fix opening relative urls from the command line
ClosedPublic

Authored by sandsmark on Apr 6 2020, 3:53 PM.

Details

Summary

The code didn't work as intended, and somewhere something was calling QUrl::fromUserInput() when adding to recently used documents. And that helpfully adds "http:" as scheme if none is set (e. g. if opening a relative file). So a lot of things broke.

Test Plan

Opening relativt paths from the command line works again.

Diff Detail

Repository
R158 Kdenlive
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sandsmark requested review of this revision.Apr 6 2020, 3:53 PM
sandsmark created this revision.
sandsmark updated this revision to Diff 79505.Apr 6 2020, 4:02 PM

Forgot to turn off noprefix when creating patch.

mardelle accepted this revision.Apr 7 2020, 9:20 AM
mardelle added a subscriber: mardelle.

Thanks a lot, can you push the change?

This revision is now accepted and ready to land.Apr 7 2020, 9:20 AM

Thanks a lot, can you push the change?

Which branch should I push to?

(I tried pushing to master, and got an error:

mardelle added a comment.EditedApr 7 2020, 1:28 PM

Which branch should I push to?

We switched to gitlab some months ago. I think you first have to log in to gitlab (https://invent.kde.org ) using the identity credentials.
Then add or switch to the gitlab remote.
git@invent.kde.org:kde/kdenlive.git

You have some instructions here: https://community.kde.org/Infrastructure/Github_Mirror
Or I can commit on your behalf if it's easier for you (will need your email adress in that case).

This revision was automatically updated to reflect the committed changes.

We switched to gitlab some months ago. I think you first have to log in to gitlab (https://invent.kde.org ) using the identity credentials.
Then add or switch to the gitlab remote.
git@invent.kde.org:kde/kdenlive.git

Ah, my bad, should've thought of that. But it worked now. :-)

Or I can commit on your behalf if it's easier for you (will need your email adress in that case).

Just for future reference (in case I forget some patch or something); martin.sandsmark@kde.org

vpinon added a subscriber: vpinon.EditedApr 7 2020, 4:25 PM

Hi Martin,
It would be nice if you joined us chatting about kdenlive dev on telegram: https://t.me/kdenlive_dev
There is also a general channel linked to IRC ##kdenlive (freenode) if you prefer: https://t.me/kdenlive, but there is much more users' traffic...
Also we plan to resurrect our monthly online "café", one evening (21h CET) some day this week to confirm. We discuss about things to do short/mid/long term.
See you!