Differential D28599

[configview] Simplify code / workaround Qt5.15 crash
ClosedPublic
Actions

Authored by davidedmundson on Apr 5 2020, 5:16 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R242:0417bf61d53a: [configview] Simplify code / workaround Qt5.15 crash
Summary

QQmlComponent::beginCreate and completeCreate are useful if you need to
set properties on the object explicitly. We're not doing that here, we
can just call create.

Test Plan

On Qt5.15
Right click a panel
choose edit

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Apr 5 2020, 5:16 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 5 2020, 5:16 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Apr 5 2020, 5:16 PM
apol accepted this revision.Apr 5 2020, 6:15 PM
apol added a subscriber: apol.

LGTM

src/plasmaquick/configview.cpp
137

It could make sense to use the opportunity to change to QQmlContext::setContextProperties.

This revision is now accepted and ready to land.Apr 5 2020, 6:15 PM
davidedmundson updated this revision to Diff 79469.Apr 6 2020, 11:31 AM

setContextProprerties

Closed by commit R242:0417bf61d53a: [configview] Simplify code / workaround Qt5.15 crash (authored by davidedmundson). · Explain WhyApr 6 2020, 11:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasmaquick/configview.cpp (9 lines)

Diff 79470

View Options

src/plasmaquick/configview.cpp

Loading...