File Size View: Convert to new Qt5 connect syntax
ClosedPublic
Actions

Authored by marten on Apr 4 2020, 7:57 AM.

Details

Reviewers

Group Reviewers

Konqueror
Plasma

Commits

R226:93c65f746949: File Size View: Convert to new Qt5 connect syntax

Summary

Convert signal-slot connections to the new Qt5 connection syntax.
The QApplication initialisation in main.cpp is moved to before the first use of i18n().

This change follows on from D28486.

Test Plan

Builds and runs (including the standalone fsview application).

Diff Detail

Repository

R226 Konqueror

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

marten requested review of this revision.Apr 4 2020, 7:57 AM

marten created this revision.

marten mentioned this in D28486: File Size View: Port away from KDElibs4Support.Apr 4 2020, 10:32 AM

dfaure accepted this revision.Apr 4 2020, 12:23 PM

dfaure added inline comments.

plugins/fsview/fsview_part.h
54	maybe make them public too. They are called (by name) via BrowserExtension.

This revision is now accepted and ready to land.Apr 4 2020, 12:23 PM

Closed by commit R226:93c65f746949: File Size View: Convert to new Qt5 connect syntax (authored by marten). · Explain WhyApr 4 2020, 3:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/fsview/fsview.cpp (3 lines)
M			plugins/fsview/fsview_part.h (18 lines)
M			plugins/fsview/fsview_part.cpp (57 lines)
M			plugins/fsview/main.cpp (11 lines)
M			plugins/fsview/treemap.cpp (18 lines)