| davidedmundson | |
| mart |
| Plasma |
The "Advanced" and "Keyboard Navigation" tabs of the mouse control panel (kcmshell5 mouse) contain a number of spin boxes, all of which were originally at their natural widths (see "before" screen shots):
This change improves the appearance by aligning them all to have the same width:
In addition to this, the spin boxes are ported from the deprecated KNumInput to QSpinBox/QDoubleSpinBox as appropriate, and some cruft (including unneeded include files) is removed.
Built mouse KCM with these changes, checked appearance and operation.
| Lint Skipped |
| Unit Tests Skipped |
| kcms/input/mouse.cpp | ||
|---|---|---|
| 796 | not sure about this manual resize. | |
A grid layout would fix it, but I assume that the point of using a form layout is that it would automatically pick up the platform and style policy (field and label alignment, stretch policy etc).
Implemented using a grid layout. It looks the same, not needing the event filter but at the cost of more code to generate the layout (getting the required label alignment, setting label buddies, keeping track of rows...) which QFormLayout does automatically.
Also, I just looked over your first patch.
That event filter was weird, but there wasn't any reason to move away from a formLayout.
you could have set a setFieldGrowthPolicy on the form layout to ExpandingFieldsGrow
Then set the spinboxes to horizontalSizeHint to minimumExpanding.
should have worked.
But the grid thing works too now you've done it.
Thanks for the hint David... I thought that I'd tried the approach of setting the fieldGrowthPolicy and the sizePolicy of the fields, and the problem with that was that the spinboxes were then extended to the full width of the form - not looking good, as well as putting the numeric values a long way away from their labels. So I remembered seeing the event filter technique used somewhere else, and did that. I'll take another look at the QFormLayout approach, though, and see if it can be made to give the right appearance.
This is what happens with a QFormLayout with fieldGrowthPolicy=ExpandingFieldsGrow and fields' sizePolicy=MinimumExpanding/Fixed. The effect is not good - it moves the spin box controls a long way away. Shall I stick with the grid layout?
Weird, with your patch I get
which looks spot on.
latest version (that uses a grid) or formlayout version with hints changed?
Urgh, I got confused. I assumed had Marten had uploaded a patch when he uploaded a screenshot. Well deduced :)
@marten can you upload your form based patch that looks wrong and I'll take a look.
I think you just need to wrap it in a hboxlayout with the form layout and a spacer.
Apologies for the confusion... this patch corresponds to the last screen shot, with ExpandingFieldsGrow and MinimumExpanding (currently only for the "Advanced" tab).
Adding an outer layout with a stretch to the right seem to be the way to go, I'll work on that.
thanks @marten for this update. If you are interested into some system setting changes let me know.
Using a form layout wrapped in an outer layout with stretch added to the right. Gives the intended effect, with all spin boxes the same size and lining up on both tabs. The boxes for the "Keyboard Navigation" tab are wider than they should be, because the check box makes the form layout wider - probably not worth the complexity of fixing, the appearance is at least better than before.
The indentation here is awful, especially the "Keyboard Navigation" block enclosed in spurious braces and then indented outwards... I've kept that which exists at the moment, and will fix in a separate commit so as not to mix code and whitespace changes.
Ship it!
I can't click approve again apparently.
I really appreciate that you put in the extra time finding the neatest solution. Good stuff.
