Differential D28496

Hotfix for D28468 to fix broken variable refs
ClosedPublic
Actions

Authored by masonm on Apr 1 2020, 11:55 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:1d777eef0b0b: Hotfix for D28468 to fix broken variable refs
Summary

Fixes broken variable references that were missed
as part of the code review changes here: https://phabricator.kde.org/D28468.

Test Plan

Same as D28468.

Diff Detail

Repository
R169 Kirigami
Branch
fix-missing-pagepool-var (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24604
Build 24622: arc lint + arc unit
masonm requested review of this revision.Apr 1 2020, 11:55 PM
masonm created this revision.
masonm added a comment.Apr 2 2020, 2:14 PM

I am going to commit some unit tests for this so I don't miss something else :)

mart accepted this revision.Apr 3 2020, 4:15 PM
This revision is now accepted and ready to land.Apr 3 2020, 4:15 PM
Closed by commit R169:1d777eef0b0b: Hotfix for D28468 to fix broken variable refs (authored by masonm). · Explain WhyApr 3 2020, 5:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/controls/PagePoolAction.qml (16 lines)

Diff 79096

View Options

src/controls/PagePoolAction.qml

Loading...