Differential D28485

Move QMimeData registration back to where it belongs
ClosedPublic
Actions

Authored by broulik on Apr 1 2020, 2:51 PM.

Details

Reviewers
ngraham
apol
Group Reviewers
Plasma
Commits
R112:92ecad19708d: Move QMimeData registration back to where it belongs
Summary

Fixes regression introduced in 7a6b1a037e65f35d86924910e24ca79ea80b4ae4

BUG: 418109
FIXED-IN: 5.18.5

Test Plan

Hmm how I didn't notice this or the bug report is beyond me :/

Broke in D26489 - my fault for accepting it but why on Earth was that call moved into a class that is clearly unused?! :(

Diff Detail

Repository
R112 Milou
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Apr 1 2020, 2:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 1 2020, 2:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Apr 1 2020, 2:51 PM
broulik edited the test plan for this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
broulik updated this revision to Diff 79055.Apr 1 2020, 2:55 PM
broulik retitled this revision from Register QMimeData to Move QMimeData registration back to where it belongs.
broulik edited the summary of this revision. (Show Details)
broulik updated this revision to Diff 79056.Apr 1 2020, 2:57 PM
  • use same 0 major as everything else

Apparently doesn't matter

ngraham accepted this revision.Apr 1 2020, 3:36 PM
ngraham added a subscriber: ngraham.

Yikes!

Stable branch, probably

This revision is now accepted and ready to land.Apr 1 2020, 3:36 PM
apol accepted this revision.Apr 1 2020, 6:48 PM
Closed by commit R112:92ecad19708d: Move QMimeData registration back to where it belongs (authored by broulik). · Explain WhyApr 2 2020, 6:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlib/previewplugin.cpp (7 lines)
Mlib/qml/qmlplugins.cpp (6 lines)

Diff 79100

View Options

lib/previewplugin.cpp

Loading...
View Options

lib/qml/qmlplugins.cpp

Loading...