Differential D2848

Fix binding loop in pager
ClosedPublic
Actions

Authored by davidedmundson on Sep 23 2016, 9:39 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:a544bd5c0ee8: Fix binding loop in pager
R119:c8d3546a9e3e: Set parent for folderview context menu actions
Summary

Previously on height changed rowHeight changed which changes columnWidth
which in turn causes rowHeight to be re-evaluated - a loop.

Moving it to a state machine solves that using a similar design pattern
to the digital clock.

Test Plan

Panel in horizontal looked normal
Panel in vertical looked normal
Moving panel back to horizontal still was fine

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 6898.Sep 23 2016, 9:39 PM
davidedmundson retitled this revision from to Fix binding loop in pager.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 23 2016, 9:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Sep 24 2016, 10:12 AM
hein added a reviewer: hein.
hein added a subscriber: hein.

Thanks!

This revision is now accepted and ready to land.Sep 24 2016, 10:12 AM
Closed by commit R119:a544bd5c0ee8: Fix binding loop in pager (authored by davidedmundson). · Explain WhySep 24 2016, 10:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6903

View Options

applets/pager/package/contents/ui/main.qml

Loading...