Differential D2841

Don't load system apps model twice
ClosedPublic
Actions

Authored by davidedmundson on Sep 23 2016, 12:54 AM.

Details

Reviewers
mart
hein
Group Reviewers
Plasma
Commits
R119:5fe0c2398218: Don't load system apps model twice
R120:affad04d31ca: Don't load system apps model twice
Summary

The system apps model is set from QML via
ComputerModel::setSystemApplications

This is always called from Kickoff, and Kickoff is the only user of this
class.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 6886.Sep 23 2016, 12:54 AM
davidedmundson retitled this revision from to Don't load system apps model twice.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 23 2016, 12:54 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Sep 23 2016, 8:59 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Sep 23 2016, 8:59 AM
hein accepted this revision.Sep 24 2016, 10:07 AM
hein added a reviewer: hein.
hein added a subscriber: hein.

IIRC there was a reason for this related to migrating from the legacy config, where stuff had to be merged ... but since I didn't add a code comment to the effect, oh well, let's try I guess.

Closed by commit R119:5fe0c2398218: Don't load system apps model twice (authored by davidedmundson). · Explain WhySep 24 2016, 10:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6905

View Options

applets/kicker/plugin/computermodel.cpp

Loading...