Differential D28391

[pc3/busyindicator] Hide when not running
ClosedPublic
Actions

Authored by nicolasfella on Mar 28 2020, 11:46 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R242:bc3ccd1782cb: [pc3/busyindicator] Hide when not running
Summary

When not running the indicator should be invisible. This matches the behaviour of the org.kde.desktop style.

Test Plan

Run KTrip with Plasma style. Open location search page. Indicator is only shown when actually loading things

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Mar 28 2020, 11:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 28 2020, 11:46 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Mar 28 2020, 11:46 PM
ngraham accepted this revision.Mar 29 2020, 2:41 AM
This revision is now accepted and ready to land.Mar 29 2020, 2:41 AM
Closed by commit R242:bc3ccd1782cb: [pc3/busyindicator] Hide when not running (authored by nicolasfella). · Explain WhyMar 29 2020, 9:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 78812

View Options

src/declarativeimports/plasmacomponents3/BusyIndicator.qml

Loading...